Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix double tests execution #38

Merged
merged 2 commits into from
Oct 4, 2018
Merged

fix double tests execution #38

merged 2 commits into from
Oct 4, 2018

Conversation

Michsior14
Copy link
Contributor

@Michsior14 Michsior14 commented Oct 3, 2018 •
edited
Loading

Previously the tests were also running on dist folder which caused doubled test execution.
This should also fix #33.

@Michsior14
Copy link
Contributor Author

The job on node 6 fails because of Error: You can only use --detectOpenHandles on Node 8 and newer.. So I suggest just testing on node >= 8.0.0 or remove the flag.

@StarpTech
Copy link
Member

Great catch! What a pitfall 😄

@StarpTech
Copy link
Member

Could you remove node 6 from Travis as well?

@Michsior14
Copy link
Contributor Author

done

@StarpTech
Copy link
Member

Thanks!

@StarpTech StarpTech merged commit 6627b13 into Prettyhtml:master Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix failing travis build
2 participants
@Michsior14 @StarpTech